azagrebin opened a new pull request #8210: [FLINK-12203] Refactor 
ResultPartitionManager to break tie with Task
URL: https://github.com/apache/flink/pull/8210
 
 
   ## What is the purpose of the change
   
   The PR is based on #8133.
   
   At the moment, we have ResultPartitionManager.releasePartitionsProducedBy 
which uses indexing by task in network environment. These methods are 
eventually used only by Task which already knows its partitions so Task can use 
ResultPartition.fail(cause) and TaskExecutor.failPartition could directly use 
NetworkEnviroment.releasePartitions(Collection<ResultPartitionID>). This also 
requires that JM Execution sends produced partition ids instead of just 
ExecutionAttemptID.
   
   Later NetworkEnviroment.releasePartitions(Collection<ResultPartitionID>) 
could be refactored into 
ShuffleService.releasePartitions(Collection<ShuffleDeploymentDescriptor>).
   
   ## Brief change log
   
     - Change Execution to send partition ids instead of execution id to 
release task produced partitions
     - Change interface of TaskExecutorGateway.failPartition to 
releasePartitions
     - Index partitions by ResultPartitionID in ResultPartitionManager
   
   ## Verifying this change
   
   The change is simple refactoring and should be addressed by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to