wuchong commented on a change in pull request #8202: [FLINK-12133]
[table-runtime-blink] Support unbounded aggregate in streaming table runtime
URL: https://github.com/apache/flink/pull/8202#discussion_r276893181
##########
File path:
flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/over/SumAggsHandleFunction.java
##########
@@ -36,7 +36,7 @@ public SumAggsHandleFunction(int inputIndex) {
}
@Override
- public void open(ExecutionContext ctx) throws Exception {
+ public void open(StateDataViewStore store) throws Exception {
Review comment:
Yes, it makes sense. But currently, `ExecutionContext` exposes
`setCurrentKey`. `KeyedProcessFunction` doesn't have the ability to set current
key, which means we can't create an instance of `ExecutionContext` in
`GroupAggFunction`.
So I'm planning to do this refactoring in
[FLINK-12215](https://issues.apache.org/jira/browse/FLINK-12215) when we
introducing a SQL own `ProcessFunction`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
