bowenli86 commented on issue #8205: [FLINK-12238] [TABLE/SQL] Support database 
related operations in GenericHiveMetastoreCatalog and setup 
flink-connector-hive module
URL: https://github.com/apache/flink/pull/8205#issuecomment-485022646
 
 
   > I think we should also add a NOTICE file to `flink-connector-hive` module, 
because it bundles hive dependency. You can take this as an example 
https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-elasticsearch2/src/main/resources/META-INF/NOTICE.
   > 
   > See more: https://cwiki.apache.org/confluence/display/FLINK/Licensing
   
   Thanks for reminding me that, @wuchong ! I propose to address it separately 
as I need a bit time to learn how to do it, and I've created 
[FLINK-12266](https://issues.apache.org/jira/browse/FLINK-12266) as an 
immediate followup. What do you think?
   
   I also remember you concluded a dev thread discussion a while ago to use 
flinkbot to remind devs on NOTICE file issues. I didn't see a flinkbot reminder 
yet. How does that go?
   
   BTW, let's all sync offline to get consensus on what component tags we 
should use for the PRs. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to