Mr-Nineteen commented on a change in pull request #8229: FLINK-12273[The
default value of CheckpointRetentionPolicy should be …
URL: https://github.com/apache/flink/pull/8229#discussion_r277189904
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##########
@@ -627,7 +627,7 @@ private void configureCheckpointing() {
CheckpointRetentionPolicy.RETAIN_ON_FAILURE :
CheckpointRetentionPolicy.RETAIN_ON_CANCELLATION;
} else {
- retentionAfterTermination =
CheckpointRetentionPolicy.NEVER_RETAIN_AFTER_TERMINATION;
+ retentionAfterTermination =
CheckpointRetentionPolicy.RETAIN_ON_FAILURE;
Review comment:
Hundreds of flink production applications, most applications do not have set
an external checkpoint cleanup. After the application fails, it cannot be
recovered according to the checkpoint, and the recovery also brings a lot of
trouble, which brings huge losses to the production service. Therefore, the
default is RETAIN_ON_FAILURE is more reasonable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
