wuchong commented on a change in pull request #8203:
[Flink-12208][table-planner-blink] Support translation from StreamExecSort /
TemporalSort / SortLimit/ Limit to StreamTransformation.
URL: https://github.com/apache/flink/pull/8203#discussion_r277197499
##########
File path:
flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/rank/BaseTopNFunctionTest.java
##########
@@ -41,14 +44,10 @@
import java.util.ArrayList;
import java.util.List;
-import static
org.apache.flink.table.runtime.util.StreamRecordUtils.deleteRecord;
-import static org.apache.flink.table.runtime.util.StreamRecordUtils.record;
-import static
org.apache.flink.table.runtime.util.StreamRecordUtils.retractRecord;
-
/**
- * Base Tests for all subclass of {@link AbstractRankFunction}.
+ * Base Tests for all subclass of {@link AbstractTopNFunction}.
*/
-abstract class BaseRankFunctionTest {
+abstract class BaseTopNFunctionTest {
Review comment:
I would suggest to use `TopNFunctionTestBase` as class name. Because a
`*Test` suffix will be recognized as JUnit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
