dawidwys commented on a change in pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema URL: https://github.com/apache/flink/pull/8214#discussion_r277543206
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogManager.java ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.catalog; + +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.table.api.CatalogAlreadyExistException; +import org.apache.flink.table.api.CatalogNotExistException; +import org.apache.flink.table.catalog.exceptions.DatabaseNotExistException; + +import java.util.Set; + +/** + * CatalogManager manages all the registered ReadableCatalog instances with unique names in a table environment. + * It has a concept of current catalog and current database, which will be used when they are not given + * when referencing meta-objects. + */ +@PublicEvolving +public interface CatalogManager { + + /** + * Register a catalog with a unique name. + * @param catalogName Catalog name. + * @param catalog catalog. + * @throws CatalogAlreadyExistException Thrown if the name is already take. + */ + void registerCatalog(String catalogName, ReadableCatalog catalog) throws CatalogAlreadyExistException; + + /** + * Get a catalog by name. + * @param catalogName Catalog name. + * @return The requested catalog. + * @throws CatalogNotExistException Thrown if the catalog doesn't exist. Review comment: ```suggestion * @throws CatalogNotExistException Thrown if the catalog doesn't exist. ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
