Aitozi commented on a change in pull request #8195: [FLINK-11915][core] Fix
miscalculation of DataInputViewStream.skip
URL: https://github.com/apache/flink/pull/8195#discussion_r277716108
##########
File path:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/DataInputViewStream.java
##########
@@ -62,7 +62,7 @@ public long skip(long n) throws IOException {
counter -= skippedBytes;
}
- return n - counter - inputView.skipBytes((int) counter);
+ return n - counter + inputView.skipBytes((int) counter);
Review comment:
A little suggestion: we can change the variable name `counter` to some like
`toSkipRemaining` or other you think better in this patch, i think it will make
the logic more explicit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
