Xeli commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-486236033 Hey @becketqin I've pushed code which replaces the `MultipleIdsMessageAcknowledgingSourceBase` as we discussed via email. I redid my local tests and everything seems to be running good now. These should cover all of your review points, could you have a look at them? Hi @haf, This latest push should make it possible to run it on older flink versions, as for your last 2 comments: Replay is supported in the sense that pubsub clients don't have to do anything special for replay to work as far as I know. Your stacktrace seems to be unrelated to this pubsub connector but rather the HA setup of flink. Maybe it's better to ask in the mailing list about this, to keep this PR clean(er). If you do think it's related to the PubSub connector I'd be happy to hear about it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
