zjffdu commented on issue #8144: [FLINK-12159]. Enable YarnMiniCluster integration test under non-secure mode URL: https://github.com/apache/flink/pull/8144#issuecomment-486502919 @tillrohrmann I am afraid that just adding yarn-site.xml explicitly via addShipFiles is not sufficient. It will also be used by JM to create TaskManager. See the following link - https://github.com/apache/flink/blob/master/flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java#L897 - https://github.com/apache/flink/blob/master/flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java#L970 And I found many unit test related code in flink-yarn/src/main which doesn't make sense to me. I think we do need to refactor the flink-yarn module. But I think this could be done in a follow-up ticket. Does it make sense to you ? For this PR, do you have any other concerns ? Thanks https://github.com/apache/flink/blob/master/flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java#L78
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
