KurtYoung commented on a change in pull request #7903:
[FLINK-11822][table-planner-blink] Introduce Flink metadata handlers
URL: https://github.com/apache/flink/pull/7903#discussion_r278413302
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/nodes/logical/FlinkLogicalAggregate.scala
##########
@@ -161,7 +162,14 @@ object FlinkLogicalAggregate {
groupSets: util.List[ImmutableBitSet],
aggCalls: util.List[AggregateCall]): FlinkLogicalAggregate = {
val cluster = input.getCluster
- val traitSet =
cluster.traitSet().replace(FlinkConventions.LOGICAL).simplify()
- new FlinkLogicalAggregate(cluster, traitSet, input, indicator, groupSet,
groupSets, aggCalls)
+ val traitSet = cluster.traitSetOf(Convention.NONE)
+ //FIXME: FlinkRelMdDistribution requires the current RelNode to compute
Review comment:
Do we have a follow-up of these FIXME? I noticed that you added tens of
FIXMEs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
