zentol commented on a change in pull request #8269: [FLINK-12285][test] Harden
savepoint relevant test cases by explicitly canceling test job
URL: https://github.com/apache/flink/pull/8269#discussion_r278555799
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/SavepointITCase.java
##########
@@ -240,13 +242,7 @@ private void restoreJobAndVerifyState(String
savepointPath, MiniClusterResourceF
client.cancel(jobId);
- FutureUtils.retrySuccessfulWithDelay(
- () -> client.getJobStatus(jobId),
- Time.milliseconds(50),
- Deadline.now().plus(Duration.ofSeconds(30)),
- status -> status == JobStatus.CANCELED,
- TestingUtils.defaultScheduledExecutor()
- );
+ waitJobCanceled(client, jobId);
Review comment:
should not be necessary since the cluster is shut down afterwards
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
