tillrohrmann commented on a change in pull request #8068: 
[FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of 
default filesystem
URL: https://github.com/apache/flink/pull/8068#discussion_r278583994
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/SnapshotDirectory.java
 ##########
 @@ -173,7 +173,7 @@ public static SnapshotDirectory permanent(@Nonnull Path 
directory) throws IOExce
        private static class TemporarySnapshotDirectory extends 
SnapshotDirectory {
 
                TemporarySnapshotDirectory(@Nonnull Path directory) throws 
IOException {
 
 Review comment:
   Let's only accept a `File` here. That way we know that it needs to be a 
local file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to