tillrohrmann commented on a change in pull request #8264: [hotfix][yarn]
userJarFiles can be a local variable
URL: https://github.com/apache/flink/pull/8264#discussion_r278591668
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
##########
@@ -739,12 +736,11 @@ public ApplicationReport startAppMaster(
1));
}
- if (jobGraph != null) {
- // add the user code jars from the provided JobGraph
- for (org.apache.flink.core.fs.Path path :
jobGraph.getUserJars()) {
- userJarFiles.add(new File(path.toUri()));
- }
- }
+ final List<File> userJarFiles = (jobGraph == null)
Review comment:
Let's deduplicate entries by using a `Set` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
