zhijiangW commented on a change in pull request #8181: [FLINK-12199][network]
Refactor IOMetrics to not distinguish between local/remote in/out bytes
URL: https://github.com/apache/flink/pull/8181#discussion_r278614937
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/InputChannelTestUtils.java
##########
@@ -150,7 +154,7 @@ public static RemoteInputChannel createRemoteInputChannel(
connectionManager,
0,
0,
-
UnregisteredMetricGroups.createUnregisteredTaskMetricGroup().getIOMetricGroup());
+ new
InputChannelMetrics(UnregisteredMetricGroups.createUnregisteredTaskMetricGroup().getIOMetricGroup()));
Review comment:
I guess we define a new method in `InputChannelTestUtils` for creating this
`InputChannelMetrics` in order to reuse in multiple places?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
