[
https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826601#comment-16826601
]
Rong Rong edited comment on FLINK-11935 at 4/26/19 2:57 AM:
------------------------------------------------------------
hmm. I might've misunderstood some details.
Are you suggesting both
{code}
1017-11-29 22:58:58.998 // current impl in Flink
{code}
and
{code}
1017-11-23 22:58:58.998 // remove DateTimeUtils, uses Calcite version
{code}
are both acceptable results of this expression:
{code}
'2017-11-29 22:58:58.998' - 1000.year
{code}
and we allow user to choose between the 2?
was (Author: walterddr):
hmm. I might've misunderstood some details.
Are you suggesting both {{1017-11-29 22:58:58.998}} (current impl in Flink) and
{{1017-11-23 22:58:58.998}} (remove DateTimeUtils, uses Calcite version) are
both acceptable results of this expression: {{'2017-11-29 22:58:58.998' -
1000.year}}, depends on how user choose?
> Remove DateTimeUtils pull-in and fix datetime casting problem
> -------------------------------------------------------------
>
> Key: FLINK-11935
> URL: https://issues.apache.org/jira/browse/FLINK-11935
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / API
> Reporter: Rong Rong
> Assignee: vinoyang
> Priority: Major
>
> This {{DateTimeUtils}} was pulled in in FLINK-7235.
> Originally the time operation was not correctly done via the {{ymdToJulian}}
> function before the date {{1970-01-01}} thus we need the fix. similar to
> addressing this problem:
> {code:java}
> Optimized :1017-12-05 22:58:58.998
> Expected :1017-11-29 22:58:58.998
> Actual :1017-12-05 22:58:58.998
> {code}
>
> However, after pulling in avatica 1.13, I found out that the optimized plans
> of the time operations are actually correct. it is in fact the casting part
> that creates problem:
> For example, the following:
> *{{(plus(-12000.months, cast('2017-11-29 22:58:58.998', TIMESTAMP))}}*
> result in a StringTestExpression of:
> *{{CAST(1017-11-29 22:58:58.998):VARCHAR(65536) CHARACTER SET "UTF-16LE"
> COLLATE "ISO-8859-1$en_US$primary" NOT NULL}}*
> but the testing results are:
> {code:java}
> Optimized :1017-11-29 22:58:58.998
> Expected :1017-11-29 22:58:58.998
> Actual :1017-11-23 22:58:58.998
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
