KurtYoung commented on a change in pull request #8275: [FLINK-11519][table] Add
function related catalog APIs
URL: https://github.com/apache/flink/pull/8275#discussion_r278816869
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMemoryCatalog.java
##########
@@ -287,7 +292,84 @@ public CatalogBaseTable getTable(ObjectPath tablePath)
throws TableNotExistExcep
@Override
public boolean tableExists(ObjectPath tablePath) {
- return tablePath != null &&
databaseExists(tablePath.getDatabaseName()) && tables.containsKey(tablePath);
+ checkNotNull(tablePath);
+
+ return databaseExists(tablePath.getDatabaseName()) &&
tables.containsKey(tablePath);
+ }
+
+ // ------ functions ------
+
+ @Override
+ public void createFunction(ObjectPath functionPath, CatalogFunction
function, boolean ignoreIfExists)
+ throws FunctionAlreadyExistException, DatabaseNotExistException
{
Review comment:
indent with 2 tabs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
