[
https://issues.apache.org/jira/browse/FLINK-12176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826841#comment-16826841
]
Till Rohrmann edited comment on FLINK-12176 at 4/26/19 10:08 AM:
-----------------------------------------------------------------
I think the unification is not so easily possible because the
{{OptimizerPlanEnvironment}} does not support eager execution calls. So
whenever you have a program using {{collect}} or {{print}}, you will only
execute the first part of it. What we would need to do is to refactor the
{{ExecutionEnvironments}} so that they are able to deploy a cluster instead of
only relying on the {{ClusterClient}} which is given to them.
Thus, I guess that we either need a proper design or can close this issue for
the moment.
was (Author: till.rohrmann):
I think the unification is not so easily possible because the
{{OptimizerPlanEnvironment}} does not support eager execution calls. So
whenever you have a program using {{collect}} or {{print}}, you will only
execute the first part of it. What we would need to do is to refactor the
{{ExecutionEnvironments}} so that they are able to deploy a cluster instead of
only relying on the {{ClusterClient}} which is given to them.
Thus, I guess that we could close this issue.
> Unify JobGraph creation in CliFrontend
> --------------------------------------
>
> Key: FLINK-12176
> URL: https://issues.apache.org/jira/browse/FLINK-12176
> Project: Flink
> Issue Type: Improvement
> Components: Command Line Client
> Affects Versions: 1.9.0
> Reporter: TisonKun
> Assignee: TisonKun
> Priority: Major
> Fix For: 1.9.0
>
>
> Currently, we create {{JobGraph}} by the following process
> * if the cluster start in job mode, we create {{JobGraph}} by
> {{PackagedProgramUtils#createJobGraph}} and deploy a job cluster
> * if the cluster start in session mode, we create {{JobGraph}} and submit it
> by {{CliFrontend#executeProgram}}, which internally the same as above but
> using {{ContextEnvironment}} instead of {{OptimizerPlanEnvironment}}.
> {{ContextEnvironment}} not only create the job graph but also submit it.
> However, the processes of {{JobGraph}} creation in job mode and session mode
> are similar. That means, we can unify the process by always create
> {{JobGraph}} by {{PackagedProgramUtils#createJobGraph}}. And,
> * in job mode, deploy job cluster with the {{JobGraph}}
> * in session mode, submit the {{JobGraph}} to the session cluster
> From a higher view, it is helpful for a common view of job submission in both
> job and session mode and give opportunities to refactor legacy client codes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
