tillrohrmann commented on a change in pull request #8224: [FLINK-12139][Mesos]
Add disk space parameter.
URL: https://github.com/apache/flink/pull/8224#discussion_r278998701
##########
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
##########
@@ -220,6 +220,7 @@ public String toString() {
taskInfo.addAllResources(allocation.takeScalar("cpus",
taskRequest.getCPUs(), roles));
taskInfo.addAllResources(allocation.takeScalar("gpus",
taskRequest.getGPUs(), roles));
taskInfo.addAllResources(allocation.takeScalar("mem",
taskRequest.getMemory(), roles));
+ taskInfo.addAllResources(allocation.takeScalar("disk",
taskRequest.getDisk(), roles));
Review comment:
Hmm, looking at the Mesos source code it seems that the disk size will be
automatically calculated if not specified. Thus, I would suggest to only set
the `"disk"` resource value if the value is larger than `0.0`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
