tillrohrmann commented on a change in pull request #8268:
[FLINK-12246][runtime] Fix can't get max_attempts_history_size value when
create ExecutionVertex
URL: https://github.com/apache/flink/pull/8268#discussion_r279001292
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -816,6 +817,9 @@ public void attachJobGraph(List<JobVertex>
topologiallySorted) throws JobExcepti
final ArrayList<ExecutionJobVertex> newExecJobVertices = new
ArrayList<>(topologiallySorted.size());
final long createTimestamp = System.currentTimeMillis();
+ int maxPriorAttemptsHistoryLength =
jobInformation.getJobConfiguration().getInteger(
Review comment:
I think the maximum prior attempts history length is a cluster configuration
option because it affects cluster operations. Therefore, it should come from
the cluster's configuration which is accessible when you construct the
`ExecutionGraph` in the `ExecutionGraphBuilder`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
