Aitozi commented on a change in pull request #8304: [hotfix]Harden 
TextInputFormatTest to avoid failure by uncleaned files
URL: https://github.com/apache/flink/pull/8304#discussion_r279252759
 
 

 ##########
 File path: 
flink-java/src/test/java/org/apache/flink/api/java/io/TextInputFormatTest.java
 ##########
 @@ -44,14 +48,34 @@
  * Tests for {@link TextInputFormat}.
  */
 public class TextInputFormatTest {
+
+       private File baseDir;
+       private final String tempDirName = "tempDir";
+
+       @Before
+       public void setUp() throws IOException {
 
 Review comment:
   Seems better, I will change it then. But a little question, why my approach 
can not ensure the file cleaned (I check and clean the related file before 
execute and after test method), Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to