walterddr commented on a change in pull request #8248: [FLINK-12309][JDBC]
JDBCOoutputFormat and JDBCAppendTableSink float behavior is not align
URL: https://github.com/apache/flink/pull/8248#discussion_r279414202
##########
File path:
flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormatTest.java
##########
@@ -133,6 +133,32 @@ public void testExceptionOnInvalidType() throws
IOException {
jdbcOutputFormat.writeRecord(row);
}
+ @Test(expected = RuntimeException.class)
Review comment:
I am assuming you are trying to catch the `"imthewrongtype"` on the last
column. but if the jdbc cast float to double fails. It will throw the same
exception and the test will still pass. I suggest let this pass by setting the
last field to `INTEGER`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
