azagrebin commented on a change in pull request #8310: [FLINK-12331][network]
Introduce partition/gate setup to decouple task registration with
NetworkEnvironment
URL: https://github.com/apache/flink/pull/8310#discussion_r279417805
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/InputGateFairnessTest.java
##########
@@ -266,13 +281,14 @@ public void testFairConsumptionRemoteChannels() throws
Exception {
// Utilities
//
------------------------------------------------------------------------
- private SingleInputGate createFairnessVerifyingInputGate(int
numberOfChannels) {
+ private SingleInputGate createFairnessVerifyingInputGate(int
numberOfChannels, NetworkBufferPool bufferPool) {
Review comment:
do we need to pass `bufferPool` here always as argument if it is a class
field?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
