[ 
https://issues.apache.org/jira/browse/FLINK-9787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829396#comment-16829396
 ] 

Robert Metzger commented on FLINK-9787:
---------------------------------------

+1 to address this.

> Change ExecutionConfig#getGlobalJobParameters to return an instance of 
> GlobalJobParameters instead of null if no custom globalJobParameters are set 
> yet
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-9787
>                 URL: https://issues.apache.org/jira/browse/FLINK-9787
>             Project: Flink
>          Issue Type: Improvement
>          Components: API / DataStream
>            Reporter: Florian Schmidt
>            Assignee: Ji Liu
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 2.0.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently when accessing ExecutionConfig#getGlobalJobParameters this will 
> return `null` if no globalJobParameters are set. This can easily lead to 
> NullPointerExceptions when used with getGlobalJobParameters.toMap()
> An easy improvement for this would be to just return a new instance of 
> GlobalJobParameters if none is set with the empty map as the parameters
> This would be a breaking change since we expose this via 
> RuntimeContext#getExecutionConfig



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to