bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add
stats related catalog APIs
URL: https://github.com/apache/flink/pull/8314#discussion_r279572488
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ReadableCatalog.java
##########
@@ -224,4 +224,54 @@ CatalogPartition getPartition(ObjectPath tablePath,
CatalogPartitionSpec partiti
*/
boolean functionExists(ObjectPath functionPath) throws CatalogException;
+ // ------ Statistics ------
+
+ /**
+ * Get the statistics of a table.
+ *
+ * @param tablePath path of the table
+ * @return the statistics of the given table
+ *
+ * @throws TableNotExistException if the table does not exist in the
catalog
+ * @throws CatalogException in case of any runtime exception
+ */
+ CatalogTableStatistics getTableStatistics(ObjectPath tablePath) throws
TableNotExistException, CatalogException;
+
+ /**
+ * Get the column statistics of a table.
+ *
+ * @param tablePath path of the table
+ * @return the column statistics of the given table
+ *
+ * @throws TableNotExistException if the table does not exist in the
catalog
+ * @throws CatalogException in case of any runtime exception
+ */
+ CatalogColumnStatistics getTableColumnStatistics(ObjectPath tablePath)
throws TableNotExistException, CatalogException;
Review comment:
What does this API try to accomplish? If this is for all columns of the
table, should it return a list of `CatalogColumnStatistics`? If it's for a
single column, should it take a column name?
Besides, what happens if this API is called on a partitioned table?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
