tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network]
Introduce the DataConsumptionException for downstream task failure
URL: https://github.com/apache/flink/pull/8242#discussion_r280479507
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/ClientTransportErrorHandlingTest.java
##########
@@ -383,9 +397,16 @@ private EmbeddedChannel createEmbeddedChannel() {
return new EmbeddedChannel(protocol.getClientChannelHandlers());
}
- private RemoteInputChannel addInputChannel(NetworkClientHandler
clientHandler)
- throws IOException {
- RemoteInputChannel rich = createRemoteInputChannel();
+ private RemoteInputChannel addInputChannel(
+ NetworkClientHandler clientHandler,
+ ResultPartitionID partitionId) throws Exception {
+ RemoteInputChannel rich = new RemoteInputChannel(
+ InputChannelTestUtils.createSingleInputGate(1),
+ 0,
+ partitionId,
+ mock(ConnectionID.class),
Review comment:
Can't we create a `ConnectionID` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
