dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system URL: https://github.com/apache/flink/pull/8335#discussion_r280736591
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/ZonedTimestampType.java ########## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.types.logical; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.table.api.ValidationException; + +import java.util.Collections; +import java.util.List; +import java.util.Objects; +import java.util.Set; + +/** + * Logical type of a timestamp WITH timezone consisting of {@code year-month-day hour:minute:second[.fractional] zone} + * with up to nanosecond precision and values ranging from {@code 0000-01-01 00:00:00.000000000 +14:59} to + * {@code 9999-12-31 23:59:59.999999999 -14:59}. Compared to the SQL standard, leap seconds (23:59:60 and + * 23:59:61) are not supported as the semantics are closer to {@link java.time.OffsetDateTime}. + * + * <p>The serialized string representation is {@code TIMESTAMP(p) WITH TIME ZONE} where {@code p} is + * the number of digits of fractional seconds (=precision). {@code p} must have a value between 0 and + * 9 (both inclusive). If no precision is specified, {@code p} is equal to 6. + * + * <p>Compared to {@link LocalZonedTimestampType}, the time zone offset information is physically + * stored in every datum. It is used individually for every computation, visualization, or communication + * to external systems. + * + * <p>A conversion from {@link java.time.ZonedDateTime} ignores the zone ID. + * + * @see TimestampType + * @see LocalZonedTimestampType + */ +@PublicEvolving +public final class ZonedTimestampType extends LogicalType { + + private static final int MIN_PRECISION = 0; + + private static final int MAX_PRECISION = 9; + + private static final int DEFAULT_PRECISION = 6; + + private static final String DEFAULT_FORMAT = "TIMESTAMP(%d) WITH TIME ZONE"; + + private static final Set<String> INPUT_CONVERSION = conversionSet( + java.time.ZonedDateTime.class.getName(), + java.time.OffsetDateTime.class.getName()); + + private static final Set<String> OUTPUT_CONVERSION = conversionSet( + java.time.OffsetDateTime.class.getName()); + + private static final Class<?> DEFAULT_CONVERSION = java.time.OffsetDateTime.class; + + /** + * Internal timestamp kind for time attribute metadata. + */ + @Internal + public enum TimestampKind { Review comment: Could we extract this and use it for all `Timestamp` types? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
