bowenli86 commented on a change in pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema URL: https://github.com/apache/flink/pull/8214#discussion_r280858643
########## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/catalog/FlinkCatalogManager.java ########## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.catalog; + +import org.apache.flink.table.api.CatalogAlreadyExistsException; +import org.apache.flink.table.api.CatalogNotExistException; +import org.apache.flink.util.StringUtils; + +import org.apache.calcite.jdbc.CalciteSchema; +import org.apache.calcite.schema.SchemaPlus; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.HashMap; +import java.util.Map; +import java.util.Set; + +import static org.apache.flink.util.Preconditions.checkArgument; +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * A CatalogManager implementation for Flink. + * TODO: [FLINK-11275] Decouple CatalogManager with Calcite + * Idealy FlinkCatalogManager should be in flink-table-api-java module. + * But due to that it currently depends on Calcite, a dependency that flink-table-api-java doesn't have right now. + * We temporarily put FlinkCatalogManager in flink-table-planner-blink. + */ +public class FlinkCatalogManager implements CatalogManager { + private static final Logger LOG = LoggerFactory.getLogger(FlinkCatalogManager.class); + + public static final String BUILTIN_CATALOG_NAME = "builtin"; + + // The catalog to hold all registered and translated tables + // We disable caching here to prevent side effects + private CalciteSchema internalSchema = CalciteSchema.createRootSchema(false, false); + private SchemaPlus rootSchema = internalSchema.plus(); + + // A map between names and catalogs. + private Map<String, ReadableCatalog> catalogs; + + // The name of the default catalog and schema + private String currentCatalogName; + + public FlinkCatalogManager() { + LOG.info("Initializing FlinkCatalogManager"); + catalogs = new HashMap<>(); + + GenericInMemoryCatalog inMemoryCatalog = new GenericInMemoryCatalog(BUILTIN_CATALOG_NAME); Review comment: I think access control/authorization is orthogonal to this problem. I'd argue that we probably should allow some types of catalog to be readable only, and we just don't enter data into them but only read data from them. With the example of Confluent Registry, it has really nice features such as fancy UI, schema evolution, compatibility check, etc. If users are already using that to manage their kafka schemas, why would they wanna use something else that don't support all these features or not natively? Support writing in Flink's Registry Catalog would be vain IMHO. The `registerTable` is a part of `TableEnvironment` in the example. With the use case above in mind, having only a`Catalog` interface and letting a catalog implement 13+ methods (the # can grow) that it doesn't support seem to be not a good design. I wonder whether we should add a `CatalogManager#getReadableWritableCatalog()` API, which can perform checks in side and `TableEnvironment` won't worry about checks anymore. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
