bowenli86 commented on a change in pull request #8337: [FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8337#discussion_r280969694
########## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalogUtil.java ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.catalog.hive; + +import org.apache.flink.table.catalog.CatalogDatabase; + +import org.apache.hadoop.hive.metastore.api.Database; + +/** + * Utils to convert meta objects between Flink and Hive for HiveCatalog. + */ +public class HiveCatalogUtil { + + private HiveCatalogUtil() { + } + + // ------ Utils ------ + + /** + * Creates a Hive database from CatalogDatabase. + */ + public static Database createHiveDatabase(String dbName, CatalogDatabase db) { + HiveCatalogDatabase hiveCatalogDatabase = (HiveCatalogDatabase) db; + + return new Database( Review comment: I got confused between 'description' and 'comment'. I've createdhttps://github.com/apache/flink/pull/8340 to complete the javadoc for description. Will address "comment" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
