[
https://issues.apache.org/jira/browse/FLINK-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734461#comment-14734461
]
ASF GitHub Bot commented on FLINK-2627:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1099#discussion_r38903902
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/UnfinishedCoGroupOperation.scala
---
@@ -61,33 +59,14 @@ class UnfinishedCoGroupOperation[L: ClassTag, R:
ClassTag](
// We have to use this hack, for some reason classOf[Array[T]] does
not work.
// Maybe because ObjectArrayTypeInfo does not accept the Scala Array
as an array class.
- val leftArrayType =
+ implicit val leftArrayType =
--- End diff --
These values should be explicitly provided, not implicitly. It makes the
code much more understandable
> Make Scala Data Set utils easier to access
> ------------------------------------------
>
> Key: FLINK-2627
> URL: https://issues.apache.org/jira/browse/FLINK-2627
> Project: Flink
> Issue Type: Improvement
> Components: Scala API
> Reporter: Sachin Goel
> Assignee: Sachin Goel
> Priority: Trivial
>
> Currently, to use the Scala Data Set utility functions, one needs to import
> {{import org.apache.flink.api.scala.DataSetUtils.utilsToDataSet}}
> This is counter-intuitive, extra complicated and should be more in sync with
> how Java utils are imported. I propose a package object which can allow
> importing utils like
> {{import org.apache.flink.api.scala.utils._}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
