sunjincheng121 commented on a change in pull request #8267:
[FLINK-12311][table][python] Add base python framework and Add Scan,
Projection, and Filter operator support
URL: https://github.com/apache/flink/pull/8267#discussion_r281000307
##########
File path: tools/verify_scala_suffixes.sh
##########
@@ -84,8 +84,9 @@ block_infected=0
# a) are not deployed during a release
# b) exist only for dev purposes
# c) no-one should depend on them
+# exclude flink-python because there are 2 flink-python module currently,
current logic goes wrong on this situation
e2e_modules=$(find flink-end-to-end-tests -mindepth 2 -maxdepth 5 -name
'pom.xml' -printf '%h\n' | sort -u | tr '\n' ',')
-excluded_modules=\!${e2e_modules//,/,\!},!flink-docs
+excluded_modules=\!${e2e_modules//,/,\!},!flink-docs,!flink-python,!flink-libraries/flink-python
Review comment:
Good points!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
