pnowojski commented on a change in pull request #8295: [FLINK-11974][runtime] Introduce StreamOperatorFactory URL: https://github.com/apache/flink/pull/8295#discussion_r281086882
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InputFormatOperatorFactory.java ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.api.operators; + +import org.apache.flink.api.common.io.InputFormat; +import org.apache.flink.core.io.InputSplit; +import org.apache.flink.streaming.api.functions.source.InputFormatSourceFunction; + +/** + * Input format source operator factory which just wrap existed {@link StreamSource}. + * + * @param <OUT> The output type of the operator + */ +public class InputFormatOperatorFactory<OUT> extends SimpleOperatorFactory<OUT> { Review comment: I think the dependency here should be reverted. `InputFormatOperatorFactory` should be an interface extending `StreamOperatorFactory`, while the concrete class `SimpleInputFormatOperatorFactory` (with the code below) would be a specialisation of the `SimpleOperatorFactory`: ``` public class SimpleInputFormatOperatorFactory<OUT> extends SimpleOperatorFactory<OUT> implements InputFormatOperatorFactory<OUT> ``` Otherwise we still didn't fix the original issue: only `SimpleOperatorFactory` can have input format or an UDF. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
