tillrohrmann commented on a change in pull request #8117: [FLINK-12115] [filesystems]: Add support for AzureFS URL: https://github.com/apache/flink/pull/8117#discussion_r281234730
########## File path: flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/util/HadoopConfigLoader.java ########## @@ -16,7 +16,7 @@ * limitations under the License. */ -package org.apache.flink.fs.s3.common; +package org.apache.flink.runtime.util; Review comment: I'm wondering whether we shouldn't put the `HadoopConfigLoader` into the `flink-fs-hadoop-shaded` module, because it is intended for self-contained fs implementations which don't read a HDFS/Yarn configuration from disk but simply instantiate the `Configuration` contained in this module. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
