KurtYoung commented on a change in pull request #8294:
[FLINK-12348][table-planner-blink]Use TableConfig in api module to replace
TableConfig in blink-planner module.
URL: https://github.com/apache/flink/pull/8294#discussion_r281450922
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/plan/batch/sql/DeadlockBreakupTest.scala
##########
@@ -38,10 +39,9 @@ class DeadlockBreakupTest extends TableTestBase {
@Test
def testSubplanReuse_SetExchangeAsBatch(): Unit = {
- util.tableEnv.getConfig.getConf.setBoolean(
- PlannerConfigOptions.SQL_OPTIMIZER_REUSE_SUB_PLAN_ENABLED, true)
- util.tableEnv.getConfig.getConf.setBoolean(
- PlannerConfigOptions.SQL_OPTIMIZER_REUSE_TABLE_SOURCE_ENABLED, true)
+ val conf = infer(util.tableEnv.getConfig).getConf
Review comment:
Can PlannerConfig directly provide the ability to get/set some single
configuration? It looks obscure through current API to set some config values.
You need to know that the configuration object is mutable after you `getConf`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
