eaglewatcherwb commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy URL: https://github.com/apache/flink/pull/8296#discussion_r281454713
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/ExecutionVertexID.java ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.scheduler.strategy; + +import org.apache.flink.runtime.executiongraph.ExecutionVertex; +import org.apache.flink.runtime.jobgraph.JobVertexID; + +import static org.apache.flink.util.Preconditions.checkArgument; +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * Id identifying {@link ExecutionVertex}. + */ +public class ExecutionVertexID { + private final JobVertexID jobVertexId; + + private final int subtaskIndex; + + public ExecutionVertexID(JobVertexID jobVertexId, int subtaskIndex) { + this.jobVertexId = checkNotNull(jobVertexId); + this.subtaskIndex = subtaskIndex; + checkArgument(subtaskIndex >= 0, "subtaskIndex must be greater than or equal to 0"); + } + + public JobVertexID getJobVertexId() { + return jobVertexId; + } + + public int getSubtaskIndex() { + return subtaskIndex; + } + + @Override + public boolean equals(Object o) { + if (this == o) { + return true; + } + + if (o == null || getClass() != o.getClass()) { + return false; + } + + ExecutionVertexID that = (ExecutionVertexID) o; + + return subtaskIndex == that.subtaskIndex && jobVertexId.equals(that.jobVertexId); + } + + @Override + public int hashCode() { + int result = jobVertexId.hashCode(); + result = 31 * result + subtaskIndex; + return result; + } + + @Override + public String toString() { + return jobVertexId + "_" + subtaskIndex; Review comment: How about using `return String.format("%s (%d)", jobVertexId, subtaskIndex);` Since `ExecutionVertex#taskNameWithSubtask` is like `myTask (2/7)` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
