dianfu commented on a change in pull request #8355: [FLINK-12330][python]Add integrated Tox for ensuring compatibility of multi-version of python. URL: https://github.com/apache/flink/pull/8355#discussion_r281501220
########## File path: flink-python/README.md ########## @@ -10,15 +10,28 @@ In this initial version only Table API is supported, you can find the documentat ## Installation -Currently, you can install PyFlink from Flink source code. -First, you need build the whole Flink project using `mvn clean install -DskipTests` and set the value of the environment variable FLINK_HOME to the `build-target` directory under the root directory of Flink. -Then enter the directory where this README.md file is located and execute `python setup.py install` to install PyFlink on your device. +Currently, we can install PyFlink from Flink source code. Enter the directory where this README.md file is located and install PyFlink on your device by executing -## Running Tests +``` +python setup.py install +``` -Currently you can perform an end-to-end test of PyFlink in the directory where this file is located with the following command: +## Running env verify example Review comment: This section seems unnecessary to me. I'm not sure in which case should we check the env manually. When users run ./dev/lint-python.sh, the env will be checked anyway. Besides, I think that adding one specific test such as test_env_verify_example.py to check the env is not necessary as lint-python.sh will fail if the env is not set correctly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
