andbul opened a new pull request #8357: [FLINK-12175] Change filling of typeHierarchy in analyzePojo, for cor… URL: https://github.com/apache/flink/pull/8357 ## What is the purpose of the change This pull request fixes bug with creating TypeInfo for POJO Classes with generic superclasses which has fields of that genric type. The problem is when we building typeHierarchy for Pojo with generic superclass we already have values in typeHierarchy array, we stopped building typehierahy and coud not extract type for fields later. ## Brief change log - Removed condition on if typeHierarchy <= 1. Changed to simple else statement cause we shoudn't stop building type hierarchy. ## Verifying this change This change added tests and can be verified as follows: - Added *PojoParametrizedTypeExtractionTest* test that validates that TypeInfo for generic field correctlly exctracted by TypeExtractor ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: yes - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
