JingsongLi commented on a change in pull request #8295: [FLINK-11974][runtime]
Introduce StreamOperatorFactory
URL: https://github.com/apache/flink/pull/8295#discussion_r281607492
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphHasherV2.java
##########
@@ -285,8 +284,8 @@ private boolean isChainable(StreamEdge edge, boolean
isChainingEnabled, StreamGr
StreamNode upStreamVertex = streamGraph.getSourceVertex(edge);
StreamNode downStreamVertex = streamGraph.getTargetVertex(edge);
- StreamOperator<?> headOperator = upStreamVertex.getOperator();
- StreamOperator<?> outOperator = downStreamVertex.getOperator();
+ StreamOperatorFactory<?> headOperator =
upStreamVertex.getOperatorFactory();
Review comment:
The hash value should not be changed:
The hash is either computed from the transformation's user-specified id or
generated in a deterministic way. user-specified id not be changed.
The generated hash is deterministic with respect to:
1.node-local properties (node ID): node ID is generated by id counter.
2.chained output nodes: Chaining strategy not be changed.
3.input nodes hashes
So I think not related to StreamOperatorFactory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
