NicoK commented on a change in pull request #8215: [FLINK-8801][yarn/s3] Fix 
jars downloading issues due to inconsistent timestamp in S3 Filesystem
URL: https://github.com/apache/flink/pull/8215#discussion_r282091820
 
 

 ##########
 File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
 ##########
 @@ -206,9 +236,9 @@ public static void deleteApplicationFiles(final 
Map<String, String> env) {
         * @return YARN resource
         */
        private static LocalResource registerLocalResource(
-                       Path remoteRsrcPath,
-                       long resourceSize,
-                       long resourceModificationTime) {
 
 Review comment:
   this is the indentation I was talking about - function parameters should be 
indented one level more 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to