zentol commented on a change in pull request #8377: [FLINK-12455][python] Move
the packaging of pyflink to flink-dist
URL: https://github.com/apache/flink/pull/8377#discussion_r282357816
##########
File path: flink-dist/pom.xml
##########
@@ -588,6 +588,31 @@ under the License.
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-antrun-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>package</id>
+ <phase>package</phase>
+ <goals>
+ <goal>run</goal>
+ </goals>
+ <configuration>
+ <target>
+ <delete>
+
<fileset dir="${project.basedir}/../flink-python/pyflink" includes="**/*.pyc"/>
Review comment:
whenever you have to move into other modules like this it is a good sign
that you're doing something that you really shouldn't. We've run into _so_ many
issues due to things like this that I'm inclined to reject this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
