dianfu commented on a change in pull request #8377: [FLINK-12455][python] Move
the packaging of pyflink to flink-dist
URL: https://github.com/apache/flink/pull/8377#discussion_r282365272
##########
File path: flink-dist/pom.xml
##########
@@ -588,6 +588,31 @@ under the License.
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-antrun-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>package</id>
+ <phase>package</phase>
+ <goals>
+ <goal>run</goal>
+ </goals>
+ <configuration>
+ <target>
+ <delete>
+
<fileset dir="${project.basedir}/../flink-python/pyflink" includes="**/*.pyc"/>
Review comment:
The original motivation of this PR is that pom is a Java kind of things and
we want to get rid of it in flink-python module and make flink-python module a
pure Python module. But considering that this may introduce another problem
just as @zentol are concerned, I'm fine to keep things there it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
