[
https://issues.apache.org/jira/browse/FLINK-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jark Wu updated FLINK-12453:
----------------------------
Summary: Simplify constructor of AggsHandlerCodeGenerator to explicitly
tell which methods need to be generated (was: StreamExecGlobalGroupAggregate
construct wrong args for AggsHandlerCodeGenerator)
> Simplify constructor of AggsHandlerCodeGenerator to explicitly tell which
> methods need to be generated
> ------------------------------------------------------------------------------------------------------
>
> Key: FLINK-12453
> URL: https://issues.apache.org/jira/browse/FLINK-12453
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
> Reporter: Jingsong Lee
> Assignee: Jark Wu
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.9.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In generateAggsHandler:
> val generator = new AggsHandlerCodeGenerator(
> CodeGeneratorContext(config),
> relBuilder,
> FlinkTypeFactory.toInternalRowType(inputRowType).getFieldTypes,
> needRetract = false,
> config.getNullCheck,
> inputFieldCopy)
> but AggsHandlerCodeGenerator args is:
> class AggsHandlerCodeGenerator(
> ctx: CodeGeneratorContext,
> relBuilder: RelBuilder,
> inputFieldTypes: Seq[InternalType],
> needRetract: Boolean,
> copyInputField: Boolean,
> needAccumulate: Boolean = true)
> Same issue to StreamExecIncrementalGroupAggregate
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
