Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1107#issuecomment-138600722
Thanks a lot for opening the pull request.
Can you change the behavior of this a little bit to make the `-n` argument
a required argument again? (if the config param is not set)
I think this behavior is the best:
if `yarn.numberOfTaskManagers` == -1 (default value): users have to supply
the `-n` argument.
If `yarn.numberOfTaskManagers` is set to `>= 1`, the value will be used by
default.
If `yarn.numberOfTaskManagers` is set to `>= 1` and the user specified
`-n`, the value of `-n` will have priority.
Can you rename the configuration value to
`yarn.defaultNumberOfTaskManagers`?
Can you add a test into the `flink-yarn-tests` which is using a
configuration file with `yarn.defaultNumberOfTaskManagers` set to `1` WITHOUT a
`-n` argument to see if everything is working as expected?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
