[
https://issues.apache.org/jira/browse/FLINK-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734990#comment-14734990
]
ASF GitHub Bot commented on FLINK-2591:
---------------------------------------
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1107#issuecomment-138600722
Thanks a lot for opening the pull request.
Can you change the behavior of this a little bit to make the `-n` argument
a required argument again? (if the config param is not set)
I think this behavior is the best:
if `yarn.numberOfTaskManagers` == -1 (default value): users have to supply
the `-n` argument.
If `yarn.numberOfTaskManagers` is set to `>= 1`, the value will be used by
default.
If `yarn.numberOfTaskManagers` is set to `>= 1` and the user specified
`-n`, the value of `-n` will have priority.
Can you rename the configuration value to
`yarn.defaultNumberOfTaskManagers`?
Can you add a test into the `flink-yarn-tests` which is using a
configuration file with `yarn.defaultNumberOfTaskManagers` set to `1` WITHOUT a
`-n` argument to see if everything is working as expected?
> Add configuration parameter for default number of yarn containers
> -----------------------------------------------------------------
>
> Key: FLINK-2591
> URL: https://issues.apache.org/jira/browse/FLINK-2591
> Project: Flink
> Issue Type: Improvement
> Components: YARN Client
> Reporter: Robert Metzger
> Assignee: Will Miao
> Priority: Minor
> Labels: starter
>
> A user complained about the requirement to always specify the number of yarn
> containers (-n) when starting a job.
> Adding a configuration value with a default value will allow users to set a
> default ;)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
