azagrebin commented on a change in pull request #7757: [FLINK-11630] Triggers
the termination of all running Tasks when shutting down TaskExecutor
URL: https://github.com/apache/flink/pull/7757#discussion_r282884262
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -335,9 +336,12 @@ private void
handleStartTaskExecutorServicesException(Exception e) throws Except
resourceManagerConnection.close();
}
+ List<CompletableFuture<Void>> failingTaskFutures = new
ArrayList<>();
for (JobManagerConnection jobManagerConnection :
jobManagerConnections.values()) {
try {
-
disassociateFromJobManager(jobManagerConnection, new FlinkException("The
TaskExecutor is shutting down."));
+ FlinkException cause = new FlinkException("The
TaskExecutor is shutting down.");
+ failTasks(failingTaskFutures,
jobManagerConnection, cause);
Review comment:
I would rather make `failTasks` return `List<CompletableFuture<Void>>`
instead of passing it as an argument
and then:
`failingTaskFutures.addAll(failTasks(jobManagerConnection, cause));`
this way it is more explicit what is happening.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
