bowenli86 commented on a change in pull request #8404: [FLINK-11476][table]
Create CatalogManager to manage multiple catalogs
URL: https://github.com/apache/flink/pull/8404#discussion_r283059466
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java
##########
@@ -55,19 +57,46 @@
* Registers an {@link ExternalCatalog} under a unique name in the
TableEnvironment's schema.
* All tables registered in the {@link ExternalCatalog} can be accessed.
*
- * @param name The name under which the externalCatalog will
be registered
+ * @param name The name under which the externalCatalog will be
registered
* @param externalCatalog The externalCatalog to register
+ * @see TableEnvironment#getCatalog(String)
+ * @see TableEnvironment#registerCatalog(String, Catalog)
+ * @deprecated the {@link ExternalCatalog} API is deprecated. Use the
corresponding {@link Catalog} API.
*/
+ @Deprecated
void registerExternalCatalog(String name, ExternalCatalog
externalCatalog);
/**
* Gets a registered {@link ExternalCatalog} by name.
*
* @param name The name to look up the {@link ExternalCatalog}
* @return The {@link ExternalCatalog}
+ * @see TableEnvironment#getCatalog(String)
+ * @see TableEnvironment#registerCatalog(String, Catalog)
+ * @deprecated the {@link ExternalCatalog} API is deprecated. Use the
corresponding {@link Catalog} API.
*/
+ @Deprecated
ExternalCatalog getRegisteredExternalCatalog(String name);
+ /**
+ * Registers a {@link Catalog} under a unique name.
+ * All tables registered in the {@link Catalog} can be accessed.
+ *
+ * @param name the name under which the catalog will be registered
+ * @param catalog the catalog to register
+ * @throws CatalogAlreadyExistsException thrown if catalog with given
name already exists
+ */
+ void registerCatalog(String name, Catalog catalog) throws
CatalogAlreadyExistsException;
+
+ /**
+ * Gets a registered {@link Catalog} by name.
+ *
+ * @param catalogName The name to look up the {@link Catalog}
Review comment:
nit: "**the** name ..."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
