dawidwys commented on issue #8417: [hotfix][javadocs] Correct the example of select for Interface Table. URL: https://github.com/apache/flink/pull/8417#issuecomment-491708839 Hi @wenhuitang. To be honest I don't think this change improves the javadoc. The result of the original example depends on how the orignal `tab` Table was defined. So it would work if e.g. the schema of tab was `(key: String, ` The average`: Integer)`. Your example has the same problem/shortcoming that it does not have the context. So your examples also can fail if a wrong Table is used. To sum up I'm -1 for this change.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
