dawidwys commented on a change in pull request #8390: [FLINK-12469][table]
Clean up catalog API on default/current database
URL: https://github.com/apache/flink/pull/8390#discussion_r283220914
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMemoryCatalog.java
##########
@@ -65,9 +64,15 @@
private final Map<ObjectPath, Map<CatalogPartitionSpec,
CatalogColumnStatistics>> partitionColumnStats;
public GenericInMemoryCatalog(String name) {
+ this(name, DEFAULT_DB);
+ }
+
+ public GenericInMemoryCatalog(String name, String defaultDatabase) {
Review comment:
Hmm, not sure if it conforms to yaml more. How do you define database
properties in the yaml file? How do you set the properties of the default db in
yaml or even in a code?
I could imagine sth like:
```
catalogs:
- name: ABC
type: in-memory
property-version: 1
default-database:
name: mydb
properties:
prop1: "prop1"
....
```
I agree it works for hive, as the databases are defined externally, but for
in-memory catalog we should not construct any complex objects in a ctor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
