tillrohrmann commented on a change in pull request #8385: [FLINK-12463][tests]
Deduplicate empty .out log file checks
URL: https://github.com/apache/flink/pull/8385#discussion_r283359476
##########
File path: flink-end-to-end-tests/test-scripts/common_ha.sh
##########
@@ -59,10 +61,8 @@ function verify_logs() {
local VERIFY_CHECKPOINTS=$2
# verify that we have no alerts
- if ! [ `cat ${OUTPUT} | wc -l` -eq 0 ]; then
- echo "FAILURE: Alerts found at the general purpose job."
- EXIT_CODE=1
- fi
+ check_logs_for_non_empty_out_files
+ EXIT_CODE=$(($EXIT_CODE+$?))
Review comment:
Wouldn't it be better to fail early with the actual exit code instead of
summing it up and potentially obfuscate what the actual problem was?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
