GJL commented on a change in pull request #8309: [FLINK-12229] [runtime]
Implement LazyFromSourcesScheduling Strategy
URL: https://github.com/apache/flink/pull/8309#discussion_r283458449
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/SchedulingTopology.java
##########
@@ -50,4 +52,11 @@
* @return Optional containing the respective scheduling result
partition or none if the partition does not exist
*/
Optional<SchedulingResultPartition>
getResultPartition(IntermediateResultPartitionID intermediateResultPartitionId);
+
+ /**
+ * Looks up the {@link InputDependencyConstraint} for the given {@link
JobVertexID}.
+ * @param jobVertexId identifying the respective job vertex id
+ * @return Optional containing the respective input dependency
constraint or none if the job vertex does not exist
+ */
+ Optional<InputDependencyConstraint>
getInputDependencyConstraint(JobVertexID jobVertexId);
Review comment:
Since `InputDependencyConstraint` is a property of the `JobVertex`, I think
it makes more sense to add this to the `SchedulingExecutionVertex` (without the
`Optional`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
