[
https://issues.apache.org/jira/browse/FLINK-12372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838762#comment-16838762
]
Gary Yao edited comment on FLINK-12372 at 5/13/19 6:01 PM:
-----------------------------------------------------------
[~tiemsn]
Generally speaking your idea is sound.
Regarding your problem: On first glance it seems that the only problematic
field in {{ScheduledUnit}} is {{vertexExecution}}, which – as far as I can tell
– is not even used by
{{org.apache.flink.runtime.jobmaster.slotpool.SchedulerImpl}}. So the
{{ExecutionSlotAllocator}} can still use this class internally (with a
{{vertexExecution}} set to {{null}}) but not offer it as part of its API. Would
this work?
I also have a question to you: Where do you put the logic in
{{ExecutionVertex#getPreferredLocationsBasedOnInputs()}}? I think it has to be
copied inside the {{ExecutionSlotAllocator}} implementation.
cc: [~till.rohrmann]
was (Author: gjy):
[~tiemsn]
Generally speaking your idea is sound.
Regarding your problem: On first glance it seems that the only problematic
field in {{ScheduledUnit}} is {{vertexExecution}}, which – as far as I can tell
– is not even used by
{{org.apache.flink.runtime.jobmaster.slotpool.SchedulerImpl}}. So the
{{ExecutionSlotAllocator}} can still use this class internally (with a
{{vertexExecution}} set to {{null}}) but not offer it as part of its API. Would
this work?
I also have a question to you: Where do you put the logic in
{{ExecutionVertex#getPreferredLocationsBasedOnInputs()}}? I think it has to be
copied inside the {{ExecutionSlotAllocator}} implementation.
> Implement ExecutionSlotAllocator
> --------------------------------
>
> Key: FLINK-12372
> URL: https://issues.apache.org/jira/browse/FLINK-12372
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Coordination
> Reporter: Gary Yao
> Assignee: shuai.xu
> Priority: Major
>
> Add and implement {{ExecutionSlotAllocator}} interface
> Design document:
> https://docs.google.com/document/d/1fstkML72YBO1tGD_dmG2rwvd9bklhRVauh4FSsDDwXU
> *Acceptance criteria*
> * {{ExecutionSlotAllocator}} interface is defined and implemented
> * interface implementation is unit tested
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
